Add support for string config fields - #5
Merged
Conversation
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
Looks good. Just one question regarding the forbidden characters:
ABuljko
marked this pull request as ready for review
August 11, 2026 17:11
robin-nitrokey
requested changes
Aug 12, 2026
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
Thanks! Please remove the outdated comment and add an entry to the changelog.
Contributor
Author
|
Should i temporarily link the nitrokey-3-firmware PR to my branch of the admin-app instead of main so that it can be tested properly |
Member
|
Yes, you can use a |
- Add FieldType::String and ConfigValueMut::String, backed by a StringView so any String<N> can be used - Put both after U8 so the existing type ids stay the same - Take the max length from the config struct; too long gives DataTooLong - Check the length before clear() so a rejected value keeps the old one - Store arbitrary UTF-8; the client sanitizes the value before displaying it - Enable the serde feature of heapless, needed for StringView's Serialize impl
robin-nitrokey
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FieldType::StringandConfigValueMut::String(&mut StringView)U8, soBool=0andU8=1stay the sameFieldType::Stringa unit variant: the max length comes from the config struct, and values that are too long giveDataTooLongStringView, so anyString<N>works: hold aString<32>and passas_mut_view()InvalidValue; the directional marks are still allowedclear(), so a rejected value keeps the old oneserdefeature ofheapless, needed forStringView'sSerializeimpl